typings: update zlib binding declarations - #65639
Open
hyemimi wants to merge 1 commit into
Open
Conversation
Signed-off-by: hyemimi <hyemi7375@gmail.com>
panva
approved these changes
Aug 29, 2026
jasnell
approved these changes
Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the
zlibinternal binding declarations to match the runtime exports frominternalBinding('zlib').The latest build exposes the following binding properties:
typings/internalBinding/zlib.d.tsalready declaredBrotliDecoder,BrotliEncoder, andZlib,but was missing declarations for
ZLIB_VERSION,ZstdCompress,ZstdDecompress, andcrc32.These exports are already registered by the native binding in
src/node_zlib.cc:They are also used by existing internal JavaScript consumers.
For example,
lib/zlib.jsreadscrc32from the binding:and creates native zstd handles through the binding:
Adding these declarations keeps the internal binding typings aligned with the runtime exports and improves type checking for existing internal consumers.